This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Add more support for mxnet_to_coreml #14222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add PReLU * Add group support in Convolution * Skip _minus_scalar and _mul_scalar
|
@pracheer could you help take a look? Thanks. |
Roshrini
added
pr-awaiting-review
pracheer
suggested changes
Feb 24, 2019
* Add spare line between comment and code * Add two spare lines between functions * Change "Convert an leakyrelu" to "Convert a leakyrelu"
* Add test_tiny_prelu_leakyrelu_random_input * Add test_really_tiny_conv_random_input_multi_group * Add test_tiny_conv_random_input_multi_group * Modify test_conv_random by adding num_group
pracheer
suggested changes
Feb 27, 2019
* Add support of "leaky" and "elu" * Add unit test for "leaky" and "elu"
pracheer
approved these changes
Mar 1, 2019
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* Add support of mxnet_to_coreml * Add PReLU * Add group support in Convolution * Skip _minus_scalar and _mul_scalar * Comply with code style * Add spare line between comment and code * Add two spare lines between functions * Change "Convert an leakyrelu" to "Convert a leakyrelu" * Check if num_group exists in param before assigning value * Add test cases for test_mxnet_converter * Add test_tiny_prelu_leakyrelu_random_input * Add test_really_tiny_conv_random_input_multi_group * Add test_tiny_conv_random_input_multi_group * Modify test_conv_random by adding num_group * Rollback to not setting num_group * Add "leaky" and "elu" in converter * Add support of "leaky" and "elu" * Add unit test for "leaky" and "elu"
nswamy
pushed a commit
that referenced
this pull request
Apr 5, 2019
* Add support of mxnet_to_coreml * Add PReLU * Add group support in Convolution * Skip _minus_scalar and _mul_scalar * Comply with code style * Add spare line between comment and code * Add two spare lines between functions * Change "Convert an leakyrelu" to "Convert a leakyrelu" * Check if num_group exists in param before assigning value * Add test cases for test_mxnet_converter * Add test_tiny_prelu_leakyrelu_random_input * Add test_really_tiny_conv_random_input_multi_group * Add test_tiny_conv_random_input_multi_group * Modify test_conv_random by adding num_group * Rollback to not setting num_group * Add "leaky" and "elu" in converter * Add support of "leaky" and "elu" * Add unit test for "leaky" and "elu"
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* Add support of mxnet_to_coreml * Add PReLU * Add group support in Convolution * Skip _minus_scalar and _mul_scalar * Comply with code style * Add spare line between comment and code * Add two spare lines between functions * Change "Convert an leakyrelu" to "Convert a leakyrelu" * Check if num_group exists in param before assigning value * Add test cases for test_mxnet_converter * Add test_tiny_prelu_leakyrelu_random_input * Add test_really_tiny_conv_random_input_multi_group * Add test_tiny_conv_random_input_multi_group * Modify test_conv_random by adding num_group * Rollback to not setting num_group * Add "leaky" and "elu" in converter * Add support of "leaky" and "elu" * Add unit test for "leaky" and "elu"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add more support for mxnet_to_coreml
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments